-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small adjustments in support of unified docs site #103
Conversation
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Nice bug fix! (Sometime in the future we should do an overall design pass on all the various types of block titles.)
I can't remember if @colegoldsmith already investigated this, but it would be nice if the automatic external link styling also applied to external links in the nav, i.e. add the external icon.
Yeah, I think the rule should be if there are no list titles in the nav, everything should get promoted up a level. |
UI bundle preview build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build failure! ❌ |
Happy to look into this in a follow up PR, the changes in this PR are going to apply for any link (external or not) in the nav that is not an xhref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Antora site build failure! ❌
|
Antora site build successful! ✅ |
These are some small adjustments made in support of the unified docs site build.
1. Style inline code blocks within summary titles
Before (top) / After (bottom)
2. Style external nav content anchors the same as xhref anchors
Before (left) / After (right)
3. Render navigation when single list structure is used
Prior to this change the nav tree would be unrendered / blank.
We have a very large amount of doc sites that use an Antora single list structure so this change facilitates rendering those nav structures without manual edits. Over time we can move toward a top level item for every link. This is what the streaming docs site looks like with this change (prior the nav did not render).