Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS word wrap for code text #105

Merged
merged 2 commits into from
Mar 12, 2024
Merged

CSS word wrap for code text #105

merged 2 commits into from
Mar 12, 2024

Conversation

colegoldsmith
Copy link
Collaborator

No description provided.

@mlr
Copy link
Contributor

mlr commented Mar 5, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Mar 5, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Mar 5, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Mar 5, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@colegoldsmith colegoldsmith linked an issue Mar 6, 2024 that may be closed by this pull request
Need better handling of long monospace strings #104
Closed
eric-schneider
eric-schneider approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@eric-schneider eric-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely solves the immediate issue with long code strings breaking tables and other elements.

However, it highlights an existing issue that I'd noticed previously, which is that the code text "background box" overlaps when there's code text on adjacent lines. But I'll file a separate issue for that since it will likely involve some design discussion to resolve.

image

@colegoldsmith colegoldsmith merged commit 7c6af8a into main Mar 12, 2024
2 checks passed
@colegoldsmith colegoldsmith deleted the code-word-wrap branch March 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-schneider eric-schneider eric-schneider approved these changes

@mlr mlr Awaiting requested review from mlr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need better handling of long monospace strings
3 participants
@colegoldsmith @mlr @eric-schneider