Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax for sample tabs [no-release] #157

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

aimurphy
Copy link
Contributor

I updated the syntax demonstrated in the example tabs to follow our agreed best practices.

@aimurphy aimurphy self-assigned this Aug 20, 2024
@mlr
Copy link
Contributor

mlr commented Aug 20, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

Copy link
Contributor

github-actions bot commented Sep 4, 2024

The preview build for this pull request has been cleaned up due to being stale.

Preview builds that were 2 weeks old or older were automatically removed to maintain a tidy GitHub Pages site.

You can rebuild the preview at any time by pushing a new commit to this pull request:

git checkout tab-format-19-aug-24
git commit --allow-empty -m 'rebuild preview'
git push origin tab-format-19-aug-24

@mlr
Copy link
Contributor

mlr commented Sep 4, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@aimurphy
Copy link
Contributor Author

aimurphy commented Sep 4, 2024

@eric-schneider when you have a few min, could you please review/approve?

@plpesvc-ds
Copy link

plpesvc-ds commented Sep 4, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@eric-schneider eric-schneider self-requested a review September 4, 2024 17:31
@eric-schneider eric-schneider changed the title Update syntax for sample tabs Update syntax for sample tabs [no-release] Sep 4, 2024
@eric-schneider
Copy link
Contributor

@aimurphy I added [no-release] to the PR title, so hopefully it appears in the auto-generated commit title when you click Squash and merge. But if doesn't, please manually add it before confirming the merge. This prevents the automation from triggering a new UI bundle release (see the README for details).

@mlr
Copy link
Contributor

mlr commented Sep 4, 2024

@aimurphy I added [no-release] to the PR title, so hopefully it appears in the auto-generated commit title when you click Squash and merge. But if doesn't, please manually add it before confirming the merge. This prevents the automation from triggering a new UI bundle release (see the README for details).

Unfortunately it is based on commit message. I ran into this the other day. We (I) should update it to look at the pr title instead. If it does get added to the merge commit it should work but it doesn’t work as well as it could

@aimurphy aimurphy merged commit 97799db into main Sep 4, 2024
2 checks passed
@aimurphy aimurphy deleted the tab-format-19-aug-24 branch September 4, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants