-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syntax for sample tabs [no-release] #157
Conversation
UI bundle preview build successful! ✅ |
The preview build for this pull request has been cleaned up due to being stale. Preview builds that were 2 weeks old or older were automatically removed to maintain a tidy GitHub Pages site. You can rebuild the preview at any time by pushing a new commit to this pull request:
|
UI bundle preview build successful! ✅ |
@eric-schneider when you have a few min, could you please review/approve? |
Antora site build successful! ✅ |
@aimurphy I added |
Unfortunately it is based on commit message. I ran into this the other day. We (I) should update it to look at the pr title instead. If it does get added to the merge commit it should work but it doesn’t work as well as it could |
I updated the syntax demonstrated in the example tabs to follow our agreed best practices.