Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add external link icon #58

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Automatically add external link icon #58

merged 2 commits into from
Dec 8, 2023

Conversation

josuebran
Copy link
Contributor

@josuebran josuebran commented Dec 6, 2023 •
edited
Loading

External Link

Add external icon automatically if href is different than docs.datastax.com

https://www.datastax.com[distinguish each paragraph,role=external,window=_blank]
https://www.datastax.com[distinguish each paragraph^]
https://www.datastax.com[distinguish each paragraph]

external-link

Use remove-ext-icon role to remove icon for external links

https://www.datastax.com[distinguish each paragraph,role=remove-ext-icon,window=_blank]

@mlr
Copy link
Contributor

mlr commented Dec 6, 2023 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Dec 6, 2023

Antora site build successful! ✅
Deploying draft to GitHub Pages.

@mlr
Copy link
Contributor

mlr commented Dec 7, 2023 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Dec 7, 2023 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

colegoldsmith
colegoldsmith approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@colegoldsmith colegoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@josuebran josuebran merged commit 4105f6c into main Dec 8, 2023
2 checks passed
@josuebran josuebran deleted the automatic-external-links branch December 8, 2023 17:47
@eric-schneider eric-schneider mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colegoldsmith colegoldsmith colegoldsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josuebran @mlr @colegoldsmith