Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set theme based first on local storage value then prefers theme media query #88

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Properly set theme based first on local storage value then prefers theme media query #88

merged 2 commits into from
Jan 31, 2024

Conversation

colegoldsmith
Copy link
Collaborator

No description provided.

@mlr
Copy link
Contributor

mlr commented Jan 29, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Jan 29, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Jan 29, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Jan 29, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@colegoldsmith colegoldsmith linked an issue Jan 29, 2024 that may be closed by this pull request
Gap at the bottom of the left nav #87
Closed
@colegoldsmith colegoldsmith merged commit bcf9b11 into main Jan 31, 2024
2 checks passed
@colegoldsmith colegoldsmith deleted the theme-fix branch January 31, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-schneider eric-schneider eric-schneider approved these changes

@mlr mlr Awaiting requested review from mlr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gap at the bottom of the left nav
3 participants
@colegoldsmith @mlr @eric-schneider