WEB3-146: Replace map types with alloy_primitives::map
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
std::collections::HashMapstd::collections::HashMap
Wollac
changed the title
std::collections::HashMapalloy_primitives::map
nategraf
approved these changes
Sep 27, 2024
Wollac
added a commit
that referenced
this pull request
Oct 1, 2024
This fixes the current compilation errors.
Previously, we used to use `revm::primitives::HashMap` to have the same
hash in Steel and `revm`. However, with the latest (minor) revm version,
this has been switched to using `alloy_primitves::map::HashMap`. Thus,
in this PR we also replace all `{Hash,BTree}{Map,Set}` with their more
performant and specific equivalent in `alloy_primitives::map`.
### Additional context
- alloy-rs/alloy#1365
Wollac
added a commit
that referenced
this pull request
Oct 7, 2024
This fixes the current compilation errors.
Previously, we used to use `revm::primitives::HashMap` to have the same
hash in Steel and `revm`. However, with the latest (minor) revm version,
this has been switched to using `alloy_primitves::map::HashMap`. Thus,
in this PR we also replace all `{Hash,BTree}{Map,Set}` with their more
performant and specific equivalent in `alloy_primitives::map`.
### Additional context
- alloy-rs/alloy#1365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current compilation errors.
Previously, we used to use
revm::primitives::HashMapto have the same hash in Steel andrevm. However, with the latest (minor) revm version, this has been switched to usingalloy_primitves::map::HashMap. Thus, in this PR we also replace all{Hash,BTree}{Map,Set}with their more performant and specific equivalent inalloy_primitives::map.Additional context
alloy_primitives::mapalloy-rs/alloy#1365