-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIR-280: Keccak2 InitCycle is deterministic 🎉 #115
Conversation
415ff0f
to
69bb91b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand enough about picus to evaluate the system of signals being generated, but the compiler-side changes all make sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the tour through the codebase earlier; this all seems clear and reasonable, now that I understand what it is trying to do.
69bb91b
to
f7c2090
Compare
I've written a bunch of code for Picus integration, and thought it would be good to open a PR at an intermediate step so it's not so ridiculously enormous. Summary of changes:
picus
:--emit=picus
option which emits picus code for components with thepicus
attribute and their transitive dependenciesInlineForPicusPass
which inlines some components to improve Picus performance (Shankara's suggestion, and doubles as a stopgap for a missing Picus feature)