Skip to content

Commit

Permalink
Call out flag differences in new CMake toolchain.
Browse files Browse the repository at this point in the history
Test: None
Bug: android/ndk#1536
Change-Id: I41b648e8c01d206eeefae56b53b2a326f95e5bf9
(cherry picked from commit a6c228b)
  • Loading branch information
DanAlbert authored and Android Build Coastguard Worker committed Jul 30, 2021
1 parent 21cff32 commit 80bb6fc
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions docs/changelogs/Changelog-r23.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,18 @@ For Android Studio issues, follow the docs on the [Android Studio site].
The latest are now posted directly to [GitHub](https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases).
* Vulkan tools source is also removed, specifically vulkan_wrapper.
It should be downloaded upstream from [GitHub](https://github.com/KhronosGroup/Vulkan-Tools).
* The toolchain file (android.toolchain.cmake) is refactored to base on cmake's
* The toolchain file (android.toolchain.cmake) is refactored to base on CMake's
integrated Android support. This new toolchain file will be enabled by default
for cmake 3.21 and newer. No user side change is expected. But if anything goes
for CMake 3.21 and newer. No user side change is expected. But if anything goes
wrong, please file a bug and set `ANDROID_USE_LEGACY_TOOLCHAIN_FILE=ON` to
restore the legacy behavior.
* When using the new behavior (when using CMake 3.21+ and not explicitly
selecting the legacy toolchain), **default build flags may change**. One
of the primary goals was to reduce the behavior differences between our
toolchain and CMake, and CMake's default flags do not always match the
legacy toolchain file. Most notably, if using `CMAKE_BUILD_TYPE=Release`,
your optimization type will likely be `-O3` instead of `-O2` or `-Oz`. See
[Issue 1536] for more information.
* [Issue 929]: `find_library` now prefers shared libraries from the sysroot over
static libraries.
* [Issue 1390]: ndk-build now warns when building a static executable with the
Expand All @@ -62,6 +69,7 @@ For Android Studio issues, follow the docs on the [Android Studio site].
[Issue 1390]: https://github.com/android/ndk/issues/1390
[Issue 1406]: https://github.com/android/ndk/issues/1406
[Issue 1452]: https://github.com/android/ndk/issues/1452
[Issue 1536]: https://github.com/android/ndk/issues/1536
[Polly]: https://polly.llvm.org/

## Known Issues
Expand Down

0 comments on commit 80bb6fc

Please sign in to comment.