Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error on Mac #769

Closed
wants to merge 1 commit into from
Closed

Fix compile error on Mac #769

wants to merge 1 commit into from

Conversation

tyfkda
Copy link

@tyfkda tyfkda commented Nov 11, 2020

Fix #745

The riscv-gdb submodle refers to fec47be which is old (2018).

In the repository, sim-core.c or some files need to include stdlib,
and it fixed in the commit below:
sim: add some stdlib.h includes · riscv/riscv-binutils-gdb@b760fb3
, which is newer than fec47be.

This change updates it to version 2.35 (current default branch).

Fix #745

The `riscv-gdb` submodle refers to `fec47be` which is old (2018).

In the repository, sim-core.c or some files need to include `stdlib`,
and it fixed in the commit below:
[sim: add some stdlib.h includes · riscvarchive/riscv-binutils-gdb@b760fb3](riscvarchive/riscv-binutils-gdb@b760fb3)
, which is newer than `fec47be`.

This change updates it to version 2.35 (current default branch).
@kito-cheng
Copy link
Collaborator

Oh, we hold gdb sim in local github only currently, so after this bump gdb sim will gone, I guess I can rebase this to gdb 10.1 in next few days.

@jim-wilson
Copy link
Collaborator

This sim problem has been going on too long.  I'd like to submit our gdb sim upstream.  The CGEN one that Embecosm has is really cool, but has the serious disadvantage that it can't handle all archi variations, and probably that is only getting worse now that we have B, V, Zfinx, Zfh and other stuff that will show up soon.

@kito-cheng
Copy link
Collaborator

@jim-wilson sounds good to hear the info, I'm glad to help if you need :)

@jim-wilson
Copy link
Collaborator

Binutils and gdb share the same source tree, but they make releases at different times, and have different release branches. We can't use a binutils branch for the gdb build. We have to use a gdb release. I just submitted pr 776 to do this the right way, bumping gdb to the FSF gdb 10.1 release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Issues on make on Mac ( Catalina)
3 participants