Merge pull request #1174 from fk-sc/fk-sc/checker-fix

target/riscv: fix memory access result type checker function return in case of assertion
riscv-collab · Nov 28, 2024 · 0f0302b · 0f0302b
2 parents eb1ecd7 + c8ae081
commit 0f0302b
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/target/riscv/riscv-013.c b/src/target/riscv/riscv-013.c
@@ -3439,26 +3439,32 @@ bool is_mem_access_failed(mem_access_result_t status)
 {
 	#define MEM_ACCESS_RESULT_HANDLER(name, kind, msg) \
 		case name: return kind == MEM_ACCESS_RESULT_TYPE_FAILED;
+
 	switch (status) {
 		LIST_OF_MEM_ACCESS_RESULTS
 	}
+
 	#undef MEM_ACCESS_RESULT_HANDLER
+
 	LOG_ERROR("Unknown memory access status: %d", status);
-	assert(false);
-	return false;
+	assert(false && "Unknown memory access status");
+	return true;
 }
 
 bool is_mem_access_skipped(mem_access_result_t status)
 {
 	#define MEM_ACCESS_RESULT_HANDLER(name, kind, msg) \
 		case name: return kind == MEM_ACCESS_RESULT_TYPE_SKIPPED;
+
 	switch (status) {
 		LIST_OF_MEM_ACCESS_RESULTS
 	}
+
 	#undef MEM_ACCESS_RESULT_HANDLER
+
 	LOG_ERROR("Unknown memory access status: %d", status);
-	assert(false);
-	return false;
+	assert(false && "Unknown memory access status");
+	return true;
 }
 
 const char *mem_access_result_to_str(mem_access_result_t status)