Merge pull request #940 from riscv/revert-908-disable-soft-bp-size-2-…

…non-compressed Revert "target/riscv: Reject size 2 soft breakpoints when C extension not supported"
riscv-collab · Oct 23, 2023 · 132e3fa · 132e3fa
2 parents 3b0561d + 912de78
commit 132e3fa
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/target/riscv/riscv.c b/src/target/riscv/riscv.c
@@ -1237,17 +1237,15 @@ static int riscv_add_breakpoint(struct target *target, struct breakpoint *breakp
 	LOG_TARGET_DEBUG(target, "@0x%" TARGET_PRIxADDR, breakpoint->address);
 	assert(breakpoint);
 	if (breakpoint->type == BKPT_SOFT) {
-		const bool c_extension_supported = riscv_supports_extension(target, 'C');
-		if (!(breakpoint->length == 4 || (breakpoint->length == 2 && c_extension_supported))) {
-			LOG_TARGET_ERROR(target, "Invalid breakpoint length %d, supported lengths: %s", breakpoint->length,
-				c_extension_supported ? "2, 4" : "4");
+		/** @todo check RVC for size/alignment */
+		if (!(breakpoint->length == 4 || breakpoint->length == 2)) {
+			LOG_TARGET_ERROR(target, "Invalid breakpoint length %d", breakpoint->length);
 			return ERROR_FAIL;
 		}
 
-		const unsigned int required_align = c_extension_supported ? 2 : 4;
-		if ((breakpoint->address % required_align) != 0) {
-			LOG_TARGET_ERROR(target, "Invalid breakpoint alignment for address 0x%" TARGET_PRIxADDR
-				", required alignment: %u", breakpoint->address, required_align);
+		if (0 != (breakpoint->address % 2)) {
+			LOG_TARGET_ERROR(target, "Invalid breakpoint alignment for address 0x%" TARGET_PRIxADDR,
+				breakpoint->address);
 			return ERROR_FAIL;
 		}