Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "target: Update messages connected with examine" #934

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

kr-sc
Copy link
Contributor

@kr-sc kr-sc commented Oct 16, 2023

This reverts commit a3db93b.

Reason for revert: #931 (comment)

Copy link
Collaborator

@timsifive timsifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the description of this PR to explain why the change needs to be reverted?

@kr-sc
Copy link
Contributor Author

kr-sc commented Oct 17, 2023

Can you update the description of this PR to explain why the change needs to be reverted?

@en-sc explained here #931 (comment)

Also, @en-sc found a bug that message LOG_TARGET_INFO(target, "Retry examination."); is printed even at the first examine atttempt.

@kr-sc kr-sc force-pushed the kr-sc/revert-commit branch from b32f868 to 6c96b9d Compare October 17, 2023 09:58
@timsifive timsifive merged commit a495dd8 into riscv-collab:riscv Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants