Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert unsigned long to uint32_t #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

steven-bellock
Copy link
Contributor

Fix #91.

Fix riscv-non-isa#91.

Signed-off-by: Steven Bellock <sbellock@nvidia.com>
@steven-bellock steven-bellock marked this pull request as ready for review December 18, 2024 15:48
@steven-bellock steven-bellock changed the title Convert unsigned long to uint32_t Convert unsigned long to uint32_t Dec 18, 2024
@rsahita
Copy link
Collaborator

rsahita commented Dec 19, 2024

@atishp04 fyi

@atishp04
Copy link
Contributor

atishp04 commented Dec 19, 2024

tsm_capabilities is a bitmask. Thus, unsigned long allow more bits for the future for more common use case for virtualization (RV64). Currently, the bitmask table is defined accordingly as well.
I don't think it matters much for tvm_max_vcpus as it is highly unlikely that you would need vcpus > UINT32_MAX anyways.

@steven-bellock
Copy link
Contributor Author

unsigned long allow more bits

We can make it uint64_t. I assume the number of capabilities will be the same for both RV32 and RV64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert unsigned long to uint*_t
3 participants