Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpretation of floating-point types #430

Closed
aswaterman opened this issue Mar 12, 2024 · 0 comments · Fixed by #443
Closed

Interpretation of floating-point types #430

aswaterman opened this issue Mar 12, 2024 · 0 comments · Fixed by #443

Comments

@aswaterman
Copy link
Contributor

The ABI indicates that float is 4 bytes and double is 8 bytes, etc., but we do not actually say that float is IEEE 754 binary32, double is IEEE 754 binary64, etc.

I think this spec is the right place for that, rather than the C API, because it is at least conceivable that alternate RISC-V C APIs supported by different ABIs would be defined that specify e.g. long double as an 8-byte type. But I'll leave it to the experts to make that decision.

Note that it does not suffice to say that the C implementation conforms to Annex F, because Annex F only specifies float and double. It leaves multiple options for long double; we want to specify long double to be IEEE 754 binary128.
cmuellner added a commit to cmuellner/riscv-elf-psabi-doc that referenced this issue Jun 25, 2024
@cmuellner
riscv-cc: Reference FP standards for FP types
10a5a2b 
As reported in riscv-non-isa#430, we define the sizes and alignments of all
floating-point types, but we don't reference the underlying
standards. This change fills this gap.

Fixes: riscv-non-isa#430.

Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
cmuellner added a commit to cmuellner/riscv-elf-psabi-doc that referenced this issue Jun 25, 2024
@cmuellner
riscv-cc: Reference FP standards for FP types
85c5507 
As reported in riscv-non-isa#430, we define the sizes and alignments of all
floating-point types, but we don't reference the underlying
standards. This change fills this gap.

Fixes: riscv-non-isa#430.

Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
cmuellner added a commit to cmuellner/riscv-elf-psabi-doc that referenced this issue Jun 25, 2024
@cmuellner
riscv-cc: Reference FP standards for FP types
8ac162d 
As reported in riscv-non-isa#430, we define the sizes and alignments of all
floating-point types, but we don't reference the underlying
standards. This change fills this gap.

Fixes: riscv-non-isa#430.

Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
@cmuellner cmuellner mentioned this issue Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

riscv-cc: Reference FP standards for FP types cmuellner/riscv-elf-psabi-doc
1 participant
@aswaterman