Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of vector type tables #436

Merged

Conversation

craigblackmore
Copy link
Contributor

Table 2 does not render for me in github. Delimiting the end of the table resolves this.

Also add newline after Table 2 header row so that it appears in bold like in Table 1.

@kito-cheng
Copy link
Collaborator

vector_type_infos.adoc is generated file, could you fix that on gen_vector_type_infos.py?

Thanks :)

* Table 1 renders incorrectly due to missing heading for column 4.  Use
same header as Table 2.
* Delimit end of table so that Table 2 renders.
@craigblackmore craigblackmore force-pushed the vec-type-table-format branch from 8f975f6 to 8fd15bd Compare May 8, 2024 13:39
@craigblackmore craigblackmore changed the title Fix rendering of vector type table 2 Fix rendering of vector type tables May 8, 2024
@craigblackmore
Copy link
Contributor Author

New changes:

  • Fixed Table 1 header.
  • Updated gen_vector_type_infos.py and regenerated.

Copy link
Collaborator

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kito-cheng kito-cheng merged commit 2092568 into riscv-non-isa:master May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants