Update 3 #27
Merged
Update 3 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lftan
commented
May 3, 2024
lftan
commented
- some chapter updates
- Fix unable display images in *.adoc issue
added 4 commits
May 3, 2024 14:25
Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
Enables single notification in this call, remove 's'. Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
Uses BASE instead of Base for service group name. Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
pathakraul
reviewed
May 6, 2024
| This service allows the AP to subscribe to HART_STATE_MANAGEMENT service group | ||
| notifications. The platform can optionally support notifications of events may | ||
| occur in the platform. PuC can send these notification messages to the AP if | ||
| they are implemented and the AP has subscribed to them. Supported event are |
pathakraul
reviewed
May 6, 2024
| hart before this service was called is platform specific. It's possible that | ||
| hart was already started or hart with specified hart-id does not exist. | ||
| Implementation should return proper error code in the status field accordingly. | ||
| This service helps to start (or power up) a hart with a specified `HART_ID`. |
There was a problem hiding this comment.
better to write This service is used to start instead of help
|
Few nits only above. Rest looks good |
added 3 commits
May 6, 2024 15:52
- Fix grammar - 80 characters per line - Refer to Hart States in SBI spec instead of local hart state table. Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
So that it can display one *.adoc per line. Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
Follow suggestion from asciidoctor/asciidoctor#1567. Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.