Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBTR typos #189

Merged
merged 2 commits into from
Dec 17, 2024
Merged

DBTR typos #189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a66d1d9
Fix typos
pdonahue-ventana Dec 10, 2024
539c368
Clarify that all harts don't have one trig_max. Each has a separate t…
pdonahue-ventana Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/ext-debug-triggers.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
The RISC-V Sdtrig extension cite:[debug_v1_0] allows machine-mode software to directly
configure debug triggers which in-turn allows native (or hosted) debugging in machine-mode
without any external debugger. Unfortunately, the debug triggers are only accessible to
the machine-mode.
machine-mode.

The SBI debug trigger extension defines a SBI based abstraction to provide native debugging
for supervisor-mode software such that it is:

. Suitable for the rich operating systems and hypervisors running in supervisor-mode.
. Allows Guest (VS-mode) and Hypervisor (HS-mode) to share debug triggers on a hart.

All harts on a RISC-V platform have a fixed number of debug triggers which is referred
Each hart on a RISC-V platform has a fixed number of debug triggers which is referred
to as `trig_max` in this SBI extension. Each debug trigger is assigned a logical index
called `trig_idx` by the SBI implementation where `-1 < trig_idx < trig_max`.

Expand All @@ -38,7 +38,7 @@ trigger called `trig_state` which is encoded as shown in <<table_dbtr_trig_state

| hw_trig_idx
| `trig_state[XLEN-1:8]`
| hardware (or physical) index of the debug rigger. This field must be ignored when
| hardware (or physical) index of the debug trigger. This field must be ignored when
`trig_state.have_hw_trig == 0`.

| reserved
Expand Down Expand Up @@ -319,7 +319,7 @@ The possible error codes returned in `sbiret.error` are shown in
|===
| Error code | Description
| SBI_SUCCESS | Triggers uninstalled successfully.
| SBI_ERR_INVALID_PARAM | One of the debug trigger with index `trig_idx` in the specified
| SBI_ERR_INVALID_PARAM | One of the debug triggers with index `trig_idx` in the specified
set of debug triggers either not mapped to any HW debug trigger
OR has `trig_idx` >= `trig_max`.
|===
Expand Down Expand Up @@ -348,7 +348,7 @@ The possible error codes returned in `sbiret.error` are shown in
|===
| Error code | Description
| SBI_SUCCESS | Triggers enabled successfully.
| SBI_ERR_INVALID_PARAM | One of the debug trigger with index `trig_idx` in the specified
| SBI_ERR_INVALID_PARAM | One of the debug triggers with index `trig_idx` in the specified
set of debug triggers either not mapped to any HW debug trigger
OR has `trig_idx` >= `trig_max`.
|===
Expand Down Expand Up @@ -376,7 +376,7 @@ The possible error codes returned in `sbiret.error` are shown in
|===
| Error code | Description
| SBI_SUCCESS | Triggers disabled successfully.
| SBI_ERR_INVALID_PARAM | One of the debug trigger with index `trig_idx` in the specified
| SBI_ERR_INVALID_PARAM | One of the debug triggers with index `trig_idx` in the specified
set of debug triggers either not mapped to any HW debug trigger
OR has `trig_idx` >= `trig_max`.
|===
Expand Down
Loading