Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zawrs extension #1663

Merged
merged 1 commit into from
May 7, 2024
Merged

Add Zawrs extension #1663

merged 1 commit into from
May 7, 2024

Conversation

ved-rivos
Copy link
Contributor

@ved-rivos ved-rivos commented May 4, 2024 •
edited
Loading

@ved-rivos ved-rivos force-pushed the zawrs branch 2 times, most recently from e2ee12b to e2834ca Compare May 4, 2024 21:45
aswaterman
aswaterman reviewed May 5, 2024
View reviewed changes
Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following through with this. I’ll try to do a code review today or tomorrow.

aswaterman
aswaterman approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would you mind addressing the one nit in the ISA parser?

@aswaterman aswaterman merged commit c81d8e7 into riscv-software-src:master May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ved-rivos @aswaterman