Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change -H flag into --halted #1823

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

YenHaoChen
Copy link
Collaborator

There is a comment about aiming at --halted but failing to achieve so. This commit provides the behavior.

Reference: bd17c7e

@rtwfroody

@YenHaoChen
Copy link
Collaborator Author

BTW, do we still want the -H flag? It is kind of a conflict with the -h (--help) flag. @rtwfroody

Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest supporting the long name only.

There is a comment about aiming at --halted but failing to achieve so.
This commit provides the behavior.
@YenHaoChen YenHaoChen changed the title Support --halted (-H) flag Change -H flag into --halted Sep 30, 2024
Copy link
Contributor

@rtwfroody rtwfroody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--halted is better for an obscure feature like this one.

@aswaterman aswaterman merged commit 1cf354f into riscv-software-src:master Oct 1, 2024
3 checks passed
@YenHaoChen YenHaoChen deleted the pr-halt branch October 2, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants