Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just need to add to RVA22 (already in RVA20). Also changed to bullet list for each separate recommendation. #306

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Just need to add to RVA22 (already in RVA20). Also changed to bullet list for each separate recommendation. #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57fda0b
Just need to add to RVA22 (already in RVA20). Also changed to bullet …
james-ball-qualcomm Nov 22, 2024
edb1d4b
Merge branch 'main' into 303-add-missing-recommendations-to-profiles
james-ball-qualcomm Nov 22, 2024
230d84f
Merge branch 'main' into 303-add-missing-recommendations-to-profiles
james-ball-qualcomm Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion arch/profile_release/RVA22.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ RVA22:
text: |
The Zfinx, Zdinx, Zhinx, Zhinxmin extensions are incompatible
with the profile mandates to support the F and D extensions.
recommendations:
- text: |
Implementations are strongly recommended to raise illegal-instruction
exceptions on attempts to execute unimplemented opcodes.
RVA22S64:
marketing_name: RVA22S64
mode: S
Expand Down Expand Up @@ -257,4 +261,8 @@ RVA22:
* Shvstvala
* Shtvala
* Shvstvecd
* Shgatpa
* Shgatpa
recommendations:
- text: |
Implementations are strongly recommended to raise illegal-instruction
exceptions on attempts to execute unimplemented opcodes.
2 changes: 1 addition & 1 deletion backends/profile_doc/templates/profile.adoc.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ associated implementation-defined parameters across all its defined profiles.
Recommendations are not strictly mandated but are included to guide implementers making design choices.

<% profile.recommendations.each do |recommendation| -%>
<%= recommendation.text %>
* <%= recommendation.text %>
<% end # each recommendation -%>
<% end # unless recommendations empty -%>

Expand Down
Loading