Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show opcode as 7-bits like all other insn for unzip and zip #181

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

psherman42
Copy link
Contributor

[ 00100 ][ 11 ] should be written as [ 0010011 ] (0x13) or OP-IMM to be consistent with all other instructions.

Also, in the Operations section, should one of the foreach loops between unzip and zip be different like, for example,

foreach(i from 0 to xlen/2-1) {
    x(rd)[i] = X(rs1)[2*i]
    x(rd)[2*i+1] = X(rs1)[i+xlen/1]
}

[ 00100 ][ 11 ] should be written as [ 0010011 ] (0x13) or OP-IMM to be consistent with all other instructions.

Signed-off-by: Paul Sherman <36460742+psherman42@users.noreply.github.com>
[ 00100 ][ 11 ] should be written as [ 0010011 ] (0x13) or OP-IMM to be consistent with all other instructions.

Signed-off-by: Paul Sherman <36460742+psherman42@users.noreply.github.com>
@psherman42 psherman42 marked this pull request as ready for review November 15, 2022 19:10
@wmat wmat merged commit 0647d74 into riscv:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants