representable range description, and some other minor clarifications #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresag01
reviewed
Jan 24, 2024
src/cap-description.adoc
Outdated
| in the expression above. If the capability address changes causing that address bit | ||
| to change, then the representable range is violated and so the tag will be cleared | ||
| by an instruction such as <<CINCOFFSET>>. This is represented by a range | ||
| of `s=2^E+MW^` in xref:cap_bounds_map[xrefstyle=short]. |
There was a problem hiding this comment.
@tariqkurd-repo : Isn't this similar to the description here?
NOTE: The encoding of the bounds depends upon the leading 1 of the address
which is used to determine the exponent. If the leading 1 of the address moves
then the bounds will need to be recalculated. Instructions like <<CINCOFFSET>>
and <<CSETADDR>> update the address field but do not recalculate the bounds.
Therefore, if the leading 1 moves relative to when the bounds were calculated
then the tag is cleared on the result as the encoding has been invalidated.
There was a problem hiding this comment.
yes - but actually that description is inaccurate which was my misunderstanding - the new description is accurate. I'll resolve the differences and push more commits.
andresag01
reviewed
Jan 24, 2024
tariqkurd-repo
changed the title
Timmmm
reviewed
Jan 24, 2024
arichardson
pushed a commit
to arichardson/riscv-cheri
that referenced
this pull request
Jan 30, 2024
also autofix of existing files fixes riscv#22 Signed-off-by: Kevin Broch <kbroch@rivosinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note clarifying how the representable region is defined, and some other minor clarifications