Remove sole reference to embedded exponent #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresag01
requested changes
Jan 25, 2024
There was a problem hiding this comment.
@Timmmm : Thanks for the change. I agree with you. However, it looks like another PR was recently merged that also used the word embedded. Could you please rebase and fix that one as well? https://github.com/riscv/riscv-cheri/pull/22/files#diff-2ac200119dffa8d1c8c860fa8f9d6614dc07cf4563a3cc1820cceb25152a12fbR506
|
(and that one uses "embedded" to mean "internal" rather than the opposite!) |
"Embedded" and "internal" have very similar meanings in English so it's pretty confusing for them to mean opposite things in CHERI. Fortunately there were only two references to "embedded" so it's easy enough to remove it.
Timmmm
force-pushed
the
user/timh/remove_embedded
branch
from
b85b94d to
a18c7ee
Compare
andresag01
approved these changes
Jan 25, 2024
|
Np. Tbh I think "embedded" is a more appropriate word which is probably why it was used there by mistake! Could change it... though maybe not worth the effort. |
|
"Internal" is the word that was used in the original CHERI spec, so it would be best to keep it for now to avoid confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Embedded" and "internal" have very similar meanings in English so it's pretty confusing for them to mean opposite things in CHERI. Fortunately there was only one reference to "embedded" so it's easy enough to remove it.