Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

414 move register layout definitions into wavedrom #431

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

wmat
Copy link
Contributor

@wmat wmat commented Nov 11, 2024

I've added several register definitions as diagrams and removed the text based descriptions. If additional register diagrams are required, please open a new issue and assign to me.

Move clicintaddr register to wavedrom diagram
Add the register diagram for clickinittrig as a bytefield-svg
diagram to accomodate long names.
Adds the xtvec register diagram using bytefield-svg to accommodate
long register names.
Adds the clicintattr register diagram.  This uses wavedrom as the
register names are short.
Fix the clicintattr diagrams.
Add the mcliccfg and scliccfg register diagrams as bytefield-svg to accomodate long
register names.
Delete several of the text based descriptions of register diagrams.
Before issuing PR this adds issue #414 to move register layout definitions to be diagrams.
@wmat wmat linked an issue Nov 11, 2024 that may be closed by this pull request
…wavedrom

Signed-off-by: Bill Traynor <wmat@riscv.org>
@jb-brelot-nxp
Copy link
Collaborator

Hi Bill,

It seems that we can t see properly the result of this pulll request since the build is failling. Could you fix it? thanks

@wmat
Copy link
Contributor Author

wmat commented Dec 9, 2024

Strange, as my local build works. Looking into it.

@wmat
Copy link
Contributor Author

wmat commented Dec 9, 2024

docs-resources has been fixed and the PDF for the PR can befound in the Actions tab.

@xiaoweish
Copy link

xiaoweish commented Dec 10, 2024

For PDF in the action tab, with Microsoft Edge version 130.0.2849.80 and PDF-Xchange Editor, both show as below
image

Here is previous version:
image

@jb-brelot-nxp
Copy link
Collaborator

@wmat it seems that now it is compiling and producing the PDF, but the content is not correct. Something is going wrong.

@wmat
Copy link
Contributor Author

wmat commented Dec 10, 2024

Interesting. This only seems to be occurring with the CLIC spec. I'm looking into it.

@wmat
Copy link
Contributor Author

wmat commented Dec 10, 2024

Was there ever a PDF build of this spec? I ask because I can't get it to build properly using the PDF theme from docs-resources. The attributes are completely ignored.

@wmat
Copy link
Contributor Author

wmat commented Dec 10, 2024

NVM, I figured out the problem. Fixing in docs-resources.

Grabbing the latest docs-resources so the PDF builds for the PR.
@wmat
Copy link
Contributor Author

wmat commented Dec 10, 2024

OK the build artifacts have a fixed PDF now for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move register layout definitions into wavedrom
3 participants