-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
414 move register layout definitions into wavedrom #431
base: master
Are you sure you want to change the base?
Conversation
Move clicintaddr register to wavedrom diagram
Add the register diagram for clickinittrig as a bytefield-svg diagram to accomodate long names.
Adds the xtvec register diagram using bytefield-svg to accommodate long register names.
Adds the clicintattr register diagram. This uses wavedrom as the register names are short.
Fix the clicintattr diagrams.
Add the mcliccfg and scliccfg register diagrams as bytefield-svg to accomodate long register names.
Delete several of the text based descriptions of register diagrams.
Before issuing PR this adds issue #414 to move register layout definitions to be diagrams.
…wavedrom Signed-off-by: Bill Traynor <wmat@riscv.org>
Hi Bill, It seems that we can t see properly the result of this pulll request since the build is failling. Could you fix it? thanks |
Strange, as my local build works. Looking into it. |
…ayout-definitions-into-wavedrom
docs-resources has been fixed and the PDF for the PR can befound in the Actions tab. |
@wmat it seems that now it is compiling and producing the PDF, but the content is not correct. Something is going wrong. |
Interesting. This only seems to be occurring with the CLIC spec. I'm looking into it. |
Was there ever a PDF build of this spec? I ask because I can't get it to build properly using the PDF theme from docs-resources. The attributes are completely ignored. |
NVM, I figured out the problem. Fixing in docs-resources. |
Grabbing the latest docs-resources so the PDF builds for the PR.
OK the build artifacts have a fixed PDF now for review. |
I've added several register definitions as diagrams and removed the text based descriptions. If additional register diagrams are required, please open a new issue and assign to me.