Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Run docker as the current user (#1630)
If you have real Docker (not Podman) then by default it will run everything as root, so your build directory is owned by root and the Makefile will not work at all because it tries to modify the build directory. This adds a flag so that Asciidoctor runs as the current user in Docker instead of root.
- Loading branch information
3539eff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Timmmm any idea why this change breaks my ISA build on Fedora 40? I'm now getting numerous errors like the following:
asciidoctor: ERROR: images/bytefield/misareg.edn: line 2: Failed to generate image: Permission denied @ dir_s_mkdir - /build/images
Note that if I revert this change, the docs build fine.
3539eff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wmat Did you try a fresh checkout of the repo? (The directory might have already been created with the wrong permissions.) If that doesn't work, I'll leave it to you and @Timmmm to figure out.
3539eff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aswaterman yep, tried a fresh checkout and have the same problem.
3539eff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this change also broke the "Release new ISA when merging a PR" workflow as well, as far as I can tell, as it hasn't successfully ran since this change was applied.
3539eff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wmat I think you should revert the PR to unblock you and the release flow, then @Timmmm can resubmit a new version if he can figure out the problem.