Clarify CBO access size #1431
Merged
Clarify CBO access size #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define access size to be size of cache block for PMP/PMA checks
aswaterman
reviewed
May 28, 2024
There was a problem hiding this comment.
Are you sure this is just a clarification? I agree this definition is the logical choice, but there's risk that implementations with PMP granularity less than cache block size used to be conformant to the spec (since this was left unspecified) and now are not.
If this has already been discussed, then I'll go ahead and merge it.
aswaterman
approved these changes
May 28, 2024
There was a problem hiding this comment.
Nevermind. After reading the discussion on riscv/riscv-CMOs#60, I agree this can be argued to just be a clarification.
ved-rivos
pushed a commit
to ved-rivos/riscv-isa-manual
that referenced
this pull request
Jul 3, 2024
Define access size to be size of cache block for PMP/PMA checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define access size to be size of cache block for PMP/PMA checks