Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro.adoc: Missreferenced chapters #1614

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

PedroAntunes178
Copy link
Contributor

@PedroAntunes178 PedroAntunes178 commented Aug 24, 2024

In section "1.3. RISC-V ISA Overview," chapters 6 and 8 are mentioned when they should have been 3 and 5, respectively. They are referenced differently from other chapters. Unlike other chapters, these have an explicit title. This modification can break the text with future changes. I don't know if this is on purpose.
Please look into it.
Thank you.

…Chapter 3)

Signed-off-by: Pedro Antunes <54639637+PedroAntunes178@users.noreply.github.com>
Signed-off-by: Pedro Antunes <54639637+PedroAntunes178@users.noreply.github.com>
src/intro.adoc Outdated Show resolved Hide resolved
Signed-off-by: Pedro Antunes <54639637+PedroAntunes178@users.noreply.github.com>
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. We should definitely purge all hard-coded chapter/section/table/figure references.

@aswaterman aswaterman enabled auto-merge (squash) August 27, 2024 01:12
@aswaterman aswaterman merged commit ddf439b into riscv:main Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants