Add support for HPM counters #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
reviewed
Feb 7, 2024
arichardson
reviewed
Feb 7, 2024
Good call, I'll add that too. |
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
from
65621a3
to
260bbb3
Compare
arichardson
reviewed
Feb 9, 2024
arichardson
reviewed
Feb 9, 2024
arichardson
reviewed
Feb 9, 2024
arichardson
reviewed
Feb 9, 2024
arichardson
reviewed
Feb 9, 2024
arichardson
reviewed
Feb 9, 2024
arichardson
reviewed
Feb 9, 2024
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
from
260bbb3
to
ff07c86
Compare
arichardson
reviewed
Feb 12, 2024
arichardson
approved these changes
Feb 12, 2024
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
2 times, most recently
from
661228a
to
549f55f
Compare
|
@billmcspadden-riscv I think it's ok if you double check this since you've also done a lot of HPM stuff. |
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
from
549f55f
to
008577f
Compare
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
from
008577f
to
eb99d93
Compare
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
from
eb99d93
to
a880990
Compare
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
from
a880990
to
023c48d
Compare
|
@billmcspadden-riscv I've rebased this. |
Timmmm
commented
Sep 2, 2024
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
from
023c48d
to
947a20d
Compare
arichardson
approved these changes
Sep 4, 2024
|
@billmcspadden-riscv please can you merge this? It's ready to go. |
Implements Hardware Performance Monitoring counters, but only by making the registers available. Their values only change if explicitly written to and all values are legal. All 32 HPM counters are always implemented (the spec says this "should" be the case), and a platform callback `sys_writable_hpm_counters` is added to allow making any of them read-only. I haven't hooked `sys_writable_hpm_counters` up to CLI flags because Codasip does not use the CLI flags and it is quite tedious, and hopefully going to change when riscv-config is used.
Timmmm
force-pushed
the
user/timh/hpmcounters
branch
from
947a20d
to
01b63cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Hardware Performance Monitoring counters, but only by making the registers available. Their values only change if explicitly written to and all values are legal.
All 32 HPM counters are always implemented (the spec says this "should" be the case), and a platform callback
sys_writable_hpm_countersis added to allow making any of them read-only. I haven't hookedsys_writable_hpm_countersup to CLI flags because Codasip does not use the CLI flags and it is quite tedious, and hopefully going to change when riscv-config is used.Finally this adds
menvcfgandsenvcfgto the CSR name map which I forgot to do previously.