Move HPM code into hpm sail file and rename it #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename `riscv_hpm_control.sail` to `riscv_zihpm.sail`, so that it's named the same as the extension. I don't think we need separate `control` and `regs` files for small extensions, and it's kind of unclear what code should go in which of those anyway. * Move the HPM register access code into that file.
jordancarlin
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
LGTM. This is definitely one that seemed like it should be moved when I was doing #592 but I didn't want to make that PR any bigger than it already was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riscv_hpm_control.sailtoriscv_zihpm.sail, so that it's named the same as the extension. I don't think we need separatecontrolandregsfiles for small extensions, and it's kind of unclear what code should go in which of those anyway.