Minor architecture cleanup #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other cur_ helpers use small case; make architecture follow the convention. Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
`architecture` is XLEN (not `xlen`, which is MXLEN) and XLEN is always defined. Returning None would mean that Sail made an error somewhere and there is no reason to poison unrelated code with it. Remove the option type from architecture and throw an interal error instead. Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
arch_to_bits can be replaced by architecture if we turn architecture into a mapping. Reduce duplication. Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
arichardson
approved these changes
Jan 29, 2025
Timmmm
added
the
will be merged
jordancarlin
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First three patches of #683.