insts_base: ignore architecture in SFENCE_VMA #722
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
architecture doesn't change the behavior, so there is no reason to complicate the code with it. The code is still suboptimal because of rhs duplication, so this should be rewritten if (when) Sail supports multiple matches like: User or (Supervisor if mstatus[TVM] == 0b1) => ... Machine or (Supervisor if mstatus[TVM] == 0b0) => ... (Separately mapping those four cases into two and matching on the two is also an option, but I'm not sure it would be clearer.) Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
arichardson
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another patch from the mstatus cleanup, #683 (comment).