Skip to content

Commit

Permalink
Update dependencies for redis 5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
daskycodes committed Nov 4, 2022
1 parent 509822e commit ada72c6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ gem 'rdoc'

platforms :rbx do
gem 'racc'
gem 'rubysl', '~> 2.0'
gem 'psych'
end

Expand Down
2 changes: 1 addition & 1 deletion fakeredis.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ Gem::Specification.new do |s|
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
s.require_paths = ["lib"]

s.add_runtime_dependency(%q<redis>, ["~> 4.1"])
s.add_runtime_dependency(%q<redis>, [">= 4.1"])
s.add_development_dependency(%q<rspec>, ["~> 3.0"])
end
4 changes: 1 addition & 3 deletions lib/redis/connection/memory.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
require 'set'
require 'redis/connection/registry'
require 'redis/connection/command_helper'
require 'redis'
require "fakeredis/command_executor"
require "fakeredis/expiring_hash"
require "fakeredis/sort_method"
Expand All @@ -17,7 +16,6 @@ module Connection
DEFAULT_REDIS_VERSION = '3.3.5'

class Memory
include Redis::Connection::CommandHelper
include FakeRedis
include SortMethod
include TransactionCommands
Expand Down

2 comments on commit ada72c6

@guilleiguaran
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not enough to get the gem compatible with redis-rb 5.0, is it?

@daskycodes
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not enough to get the gem compatible with redis-rb 5.0, is it?

You are right @guilleiguaran, there are more code related changes needed to make it work with redis-rb 5.0. We decided to use an actual redis instance for our tests, so that's why we didn't continue looking further into it.

Please sign in to comment.