Localizes user date #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An example of what this would look like in Slack's own Block kit builder: https://app.slack.com/block-kit-builder/T0266FRGM#%7B%22blocks%22:%5B%7B%22type%22:%22section%22,%22text%22:%7B%22type%22:%22mrkdwn%22,%22text%22:%22%3C!date%5E1600559159%5E%7Bdate_short_pretty%7D%20at%20%7Btime%7D%7Cbackup%3E%22%7D%7D%5D%7D
Wouldn't make sense to say "on tomorrow," "on yesterday" etc Will now be something like "New Journal entry from @luke | Today at 5:00PM:"
Testing this from github codespaces - pretty cool
looks like codespaces don't come with prettier installed
|
@lukec11 Can you update the imports for the rest of the files? |
rishiosaur
requested changes
Sep 20, 2020
|
@lukec11 any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for the many commits — Just tested out GitHub codespaces, it's pretty cool but doesn't really match up to a local dev environment if that's available to you. In this situation I think it would've been easier to just use the GitHub web thing the whole way.
Anyway, I haven't used typescript for any significant amount of time before - if I messed something up, let me know and I will fix!