-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider exposing pre-built engines
public
#153
Comments
Sure, feel free to send a PR to do that. I'm also thinking if we need to have different crates for each engine. e.g., sqllogictest-postgres, sqllogictest-postgres-extended, so that it can be better leveraged by other projects. |
Good advice! I'll first try to extract them into a new crate named |
It makes total sense, and actually arrow-datafusion has similar needs apache/datafusion#4834 (comment) cc @alamb |
Just came up with a little quesion: how should the new crate be versioned? 🤔 Will there be any compatibility issues for combination of versions etc? related, although different: #152 |
The way we handle this in arrow-rs / parquet is not to try and test with various different versions, but always increment the different subcrates in lockstep even if it isn't strictly necessary to do so and still conform to semver. Basically we didn't feel we had the time to do the proper testing of different versions So that would mean everytime you released a sqllogic version you would release an upgrade of the underlying engine as well |
I guess so. I've tried to implement my own So maybe we can decouple the version of |
Hi, thanks for your awesome work! I'm a developer from RisingWave Labs 😄, and we're recently developing our customized simulation tester with the
sqllogictest
library.RisingWave is a database that is mostly compatible with the PostgreSQL wire protocol. To implement a runner for the simulated RisingWave, we have to copy the code from
bin/source/engines/postgres.rs
and slightly wrap it with some other logic. This can actually be achieved by forwarding the implementation to thePostgres as AsyncDb
, so I'm considering whether it's possible to expose this pre-built engine so that we can have better synchronization with the upstream?If you don't mind, I can submit a PR to work on it. 🥰
The text was updated successfully, but these errors were encountered: