refactor: expose built-in engines to sqllogictest-engines crate
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
|
cc @xxchan @wangrunji0408 @skyzh PTAL. 🥰 BTW, should I do something else for adding a new crate? |
|
It seems the file |
xxchan
approved these changes
Jan 18, 2023
sqllogictest-engine/Cargo.toml
Outdated
| @@ -0,0 +1,33 @@ | |||
| [package] | |||
| name = "sqllogictest-engine" | |||
| version = { workspace = true } | |||
There was a problem hiding this comment.
We can begin to use separated versions? 🤪
There was a problem hiding this comment.
I'm not sure, but it seems not bad for using a unified version 🤣 which is less ambiguous for users.
sqllogictest-engine/Cargo.toml
Outdated
| serde_json = "1" | ||
| sqllogictest = { path = "../sqllogictest", version = "0.11" } | ||
| thiserror = "1" | ||
| tokio = { version = "1", features = [ |
There was a problem hiding this comment.
I'm struggling with this too. Depending on tokio means that this cannot be directly used in madsim. 🥺 We need to fork it and replace tokio with madsim-tokio.
BugenZhao
changed the title
sqllogictest-engine cratesqllogictest-engine crate
BugenZhao
changed the title
sqllogictest-engine cratesqllogictest-engines crate
wangrunji0408
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add a new workspace member of
sqllogictest-engine, which contains pre-built engines likePostgresSimple,PostgresExtended, andExternalDriver. Developers can directly depend on thesqllogictest-enginecrate to utilize them.enginespublic #153