feat: exposed file_size_in_bytes #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxhZs
force-pushed
the
xxh/support-datafusion-0325
branch
from
9346847 to
46b61bf
Compare
…avelabs/iceberg-rust into xxh/support-datafusion-0325
Li0k
changed the title
chenzl25
reviewed
May 23, 2025
Collaborator
chenzl25
left a comment
chenzl25
left a comment
There was a problem hiding this comment.
What's the purpose of this PR？
chenzl25
approved these changes
May 29, 2025
| // under the License. | ||
|
|
||
| pub(crate) mod expr_to_predicate; | ||
| pub mod expr_to_predicate; |
Author
There was a problem hiding this comment.
DataFusion requires a conversion method in this mod
| pub use error::*; | ||
|
|
||
| mod physical_plan; | ||
| pub mod physical_plan; |
Collaborator
|
Hi @xxhZs Can you add description about the purpose of this PR, and submit a PR to upstream? |
Li0k
added a commit
that referenced
this pull request
Nov 13, 2025
* fix: delete file lost wake Signed-off-by: xxchan <xxchan22f@gmail.com> * . Signed-off-by: xxchan <xxchan22f@gmail.com> * . Signed-off-by: xxchan <xxchan22f@gmail.com> * revert * typo --------- Signed-off-by: xxchan <xxchan22f@gmail.com> Co-authored-by: xxchan <xxchan22f@gmail.com> Co-authored-by: Li0k <yuli@singularity-data.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?