Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: The WatermarkFilter and StreamSort operator #2

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Conversation

TennyZhuang
Copy link
Contributor

Signed-off-by: TennyZhuang zty0826@gmail.com

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang

This comment was marked as resolved.

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang marked this pull request as ready for review October 26, 2022 08:31
@TennyZhuang TennyZhuang changed the title add template for watermark-filter add watermark_filter Oct 26, 2022
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang marked this pull request as draft October 31, 2022 05:11
@TennyZhuang TennyZhuang marked this pull request as ready for review October 31, 2022 05:11
@liurenjie1024
Copy link
Contributor

Here is databrick sql's syntax: https://docs.databricks.com/sql/language-manual/sql-ref-window-functions.html It's much more concise than pg.

* add watermark_strategy_expression

* fix typo

* fix mistake

* Update rfcs/0002-watermark-filter.md

Co-authored-by: Bugen Zhao <i@bugenzhao.com>

* Update rfcs/0002-watermark-filter.md

Co-authored-by: Bugen Zhao <i@bugenzhao.com>

Co-authored-by: Bugen Zhao <i@bugenzhao.com>
@fuyufjh fuyufjh changed the title add watermark_filter RFC: The WatermarkFilter and StreamSort operator Dec 6, 2022
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this.

@fuyufjh fuyufjh merged commit 1eb8b62 into main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants