Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Apache Iceberg Hints #196

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix Apache Iceberg Hints #196

merged 2 commits into from
Jan 22, 2025

Conversation

hatamiarash7
Copy link
Contributor

@hatamiarash7 hatamiarash7 commented Jan 11, 2025 •
edited
Loading

The guidance for the type key is incorrect in the parameters section. There isn't any appendonly type.

Also, add an inline code style for type hints.

@hatamiarash7
docs: fix append-only hint for apache-iceberg
7bfa7db 
Signed-off-by: Arash Hatami <hatamiarash7@gmail.com>
@hatamiarash7
docs: add inline code style for type hints
e615cf9 
Signed-off-by: Arash Hatami <hatamiarash7@gmail.com>
WanYixian
WanYixian approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out

@WanYixian WanYixian merged commit 1c0c1c4 into risingwavelabs:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WanYixian WanYixian WanYixian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hatamiarash7 @WanYixian