fix(test): pass user name for regress tests (#3854)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
risingwavelabs · Jul 14, 2022 · 048587d · 048587d
1 parent 9b0d3a1
commit 048587d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/src/tests/regress/README.md b/src/tests/regress/README.md
@@ -25,11 +25,13 @@ tests: boolean
 * Run 
 ```shell
 RUST_BACKTRACE=1 target/debug/risingwave_regress_test -h 127.0.0.1 \
-  -p 4567 \
+  -p 4566 \
+  -u root \
   --input `pwd`/src/tests/regress/data \
   --output `pwd`/src/tests/regress/output \
   --schedule `pwd`/src/tests/regress/data/schedule
 ```
+Please remove the `output` directory before running the test again.
 
 # Reference
 

diff --git a/src/tests/regress/src/opts.rs b/src/tests/regress/src/opts.rs
@@ -52,6 +52,10 @@ impl Opts {
         SocketAddrV4::new(self.pg_server_host, self.pg_server_port)
     }
 
+    pub(crate) fn pg_user_name(&self) -> &str {
+        &self.pg_user_name
+    }
+
     pub(crate) fn log4rs_config_path(&self) -> &Path {
         self.log4rs_config.as_path()
     }

diff --git a/src/tests/regress/src/schedule.rs b/src/tests/regress/src/schedule.rs
@@ -184,21 +184,26 @@ impl Schedule {
 impl TestCase {
     async fn run(self) -> anyhow::Result<TestResult> {
         let mut command = Command::new("psql");
-        command.args([
+        let args = [
             "-X",
             "-a",
             "-q",
             "-h",
-            self.opts.host().as_str(),
+            &self.opts.host().to_string(),
             "-p",
-            format!("{}", self.opts.port()).as_str(),
+            &self.opts.port().to_string(),
             "-d",
             self.opts.database_name(),
+            "-U",
+            self.opts.pg_user_name(),
             "-v",
             "HIDE_TABLEAM=on",
             "-v",
             "HIDE_TOAST_COMPRESSION=on",
-        ]);
+        ];
+        command.args(args);
+
+        println!("Ready to run command:\npsql {}", args.join(" "));
 
         let input_path = self.file_manager.source_of(&self.test_name)?;
         let input_file = File::options()
@@ -266,11 +271,6 @@ impl TestCase {
         if expected_output == actual_output {
             Ok(Same)
         } else {
-            error!(
-                "Expected output of [{}] is different from actual output.\n{}",
-                self.test_name,
-                format_diff(&expected_output, &actual_output)
-            );
             Ok(Different)
         }
     }