trigger split stat on checkpoint

risingwavelabs · May 16, 2024 · 488a3e2 · 488a3e2
1 parent b0ff40e
commit 488a3e2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/meta/src/hummock/manager/checkpoint.rs b/src/meta/src/hummock/manager/checkpoint.rs
@@ -33,7 +33,7 @@ use tracing::warn;
 use crate::hummock::error::Result;
 use crate::hummock::manager::versioning::Versioning;
 use crate::hummock::manager::{read_lock, write_lock};
-use crate::hummock::metrics_utils::trigger_gc_stat;
+use crate::hummock::metrics_utils::{trigger_gc_stat, trigger_split_stat};
 use crate::hummock::HummockManager;
 
 #[derive(Default)]
@@ -235,6 +235,7 @@ impl HummockManager {
 
         let min_pinned_version_id = versioning.min_pinned_version_id();
         trigger_gc_stat(&self.metrics, &versioning.checkpoint, min_pinned_version_id);
+        trigger_split_stat(&self.metrics, &versioning.current_version);
         drop(versioning_guard);
         timer.observe_duration();
         self.metrics

diff --git a/src/meta/src/hummock/manager/mod.rs b/src/meta/src/hummock/manager/mod.rs
@@ -83,8 +83,8 @@ use crate::hummock::error::{Error, Result};
 use crate::hummock::metrics_utils::{
     build_compact_task_level_type_metrics_label, get_or_create_local_table_stat,
     trigger_delta_log_stats, trigger_local_table_stat, trigger_lsm_stat, trigger_mv_stat,
-    trigger_pin_unpin_snapshot_state, trigger_pin_unpin_version_state, trigger_split_stat,
-    trigger_sst_stat, trigger_version_stat, trigger_write_stop_stats,
+    trigger_pin_unpin_snapshot_state, trigger_pin_unpin_version_state, trigger_sst_stat,
+    trigger_version_stat, trigger_write_stop_stats,
 };
 use crate::hummock::sequence::next_compaction_task_id;
 use crate::hummock::{CompactorManagerRef, TASK_NORMAL};
@@ -2566,8 +2566,6 @@ impl HummockManager {
                                             compaction_group_config.group_id(),
                                         )
                                     }
-
-                                    trigger_split_stat(&hummock_manager.metrics, &current_version);
                                 }
 
                                 HummockTimerEvent::CompactionHeartBeatExpiredCheck => {