Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve array_replace for more element types #10168

Open
xiangjinwu opened this issue Jun 5, 2023 · 1 comment
Open

Improve array_replace for more element types #10168

xiangjinwu opened this issue Jun 5, 2023 · 1 comment
Assignees
Labels
no-issue-activity type/enhancement Improvements to existing implementation. type/refactor

Comments

@xiangjinwu
Copy link
Contributor

The initial implementation in #10166 has 2 limitations:

  • Does not support recursively replacing the base element of a multidimensional array. For example, select array_replace(array[array[array[0, 1], array[2, 3]], array[array[4, 5], array[6, 7]]], 3, 9);
  • Requires explicitly listing all data types despite the implementation being generic. This is error prone when we add new data type support.
@xiangjinwu xiangjinwu added type/enhancement Improvements to existing implementation. type/refactor labels Jun 5, 2023
@xiangjinwu xiangjinwu added this to the future-release-0.21 milestone Jun 5, 2023
@xiangjinwu xiangjinwu self-assigned this Jun 5, 2023
@xiangjinwu xiangjinwu removed this from the release-1.1 milestone Jul 28, 2023
Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity type/enhancement Improvements to existing implementation. type/refactor
Projects
None yet
Development

No branches or pull requests

1 participant