Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0-rt.1 tpch q15 performance degradation #18268

Closed
cyliu0 opened this issue Aug 27, 2024 · 5 comments
Closed

v2.0.0-rt.1 tpch q15 performance degradation #18268

cyliu0 opened this issue Aug 27, 2024 · 5 comments
Labels
type/bug Something isn't working
Milestone

Comments

@cyliu0
Copy link
Collaborator

cyliu0 commented Aug 27, 2024

Describe the bug

http://metabase.risingwave-cloud.xyz/question/26990-rw-avg-source-throughput-release?start_date=2024-07-01&testbed=medium-1cn-affinity&workload=tpch-q15
image

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@cyliu0 cyliu0 added the type/bug Something isn't working label Aug 27, 2024
@github-actions github-actions bot added this to the release-2.1 milestone Aug 27, 2024
@lmatz
Copy link
Contributor

lmatz commented Aug 27, 2024

Is it an issue of recording the wrong end time due to some unknown reason?

https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-datasource=Prometheus:%20test-useast1-eks-a&from=1723828156000&to=1723829176000&var-namespace=tpch-benchmark-wyw1vg

SCR-20240827-npt

https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?from=1724158206000&orgId=1&to=1724160025000&var-datasource=Prometheus:+test-useast1-eks-a&var-namespace=tpch-benchmark-ngn0u

SCR-20240827-npp

When clicking by the URL, the second screenshot has a period of 0 throughput at the second half period, but somehow it is still counted into the calculation

I think the system is ok, no regression if you exclude the second half period

@lmatz
Copy link
Contributor

lmatz commented Aug 27, 2024

what are the criteria for determining the end time?

@hzxa21
Copy link
Collaborator

hzxa21 commented Aug 28, 2024

Is it an issue of recording the wrong end time due to some unknown reason?

https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-datasource=Prometheus:%20test-useast1-eks-a&from=1723828156000&to=1723829176000&var-namespace=tpch-benchmark-wyw1vg

SCR-20240827-npt

https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?from=1724158206000&orgId=1&to=1724160025000&var-datasource=Prometheus:+test-useast1-eks-a&var-namespace=tpch-benchmark-ngn0u

SCR-20240827-npp

When clicking by the URL, the second screenshot has a period of 0 throughput at the second half period, but somehow it is still counted into the calculation

I think the system is ok, no regression if you exclude the second half period

From the second grafana, I saw that there is actor throughput between fragment 135 and 141 after source throughput drops to 0:

image
image

@lmatz
Copy link
Contributor

lmatz commented Aug 28, 2024

solved by #18302

@lmatz lmatz closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants