Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable sink decouple for trivial sink #18302

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Aug 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Sink decoupling is not applicable to trivial sink because it introduces overhead with no benefits.

Sink decoupling will also make "Write Ops" > 0 even if source throughput drops to 0 because sink log store will write one row per barrier regardless of whether the barrier is empty, which may confuse the perf pipeline.

Related: #18181, #18268

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 enabled auto-merge August 28, 2024 10:56
@hzxa21 hzxa21 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit befb04f Aug 28, 2024
29 of 30 checks passed
@hzxa21 hzxa21 deleted the patrick/disable-sink-decouple-trivial-sink branch August 28, 2024 11:31
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
Co-authored-by: Zhanxiang (Patrick) Huang <hzxa21@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants