Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo clippy failed on macos #5652

Closed
yuhao-su opened this issue Sep 29, 2022 · 2 comments · Fixed by #5667
Closed

cargo clippy failed on macos #5652

yuhao-su opened this issue Sep 29, 2022 · 2 comments · Fixed by #5667
Assignees
Labels
type/bug Something isn't working

Comments

@yuhao-su
Copy link
Contributor

Describe the bug

warning: item in documentation is missing backticks
  --> src/frontend/src/expr/type_inference/cast.rs:70:5
   |
70 | /// array_idx and element_idx indicate which element in inputs is the array and which the element
   |     ^^^^^^^^^
   |
   = note: requested on the command line with `-W clippy::doc-markdown`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
   |
70 | /// `array_idx` and element_idx indicate which element in inputs is the array and which the element
   |     ~~~~~~~~~~~

warning: item in documentation is missing backticks
  --> src/frontend/src/expr/type_inference/cast.rs:70:19
   |
70 | /// array_idx and element_idx indicate which element in inputs is the array and which the element
   |                   ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
   |
70 | /// array_idx and `element_idx` indicate which element in inputs is the array and which the element
   |                   ~~~~~~~~~~~~~

warning: item in documentation is missing backticks
  --> src/frontend/src/expr/type_inference/cast.rs:71:15
   |
71 | ///  Example: align_array_and_element(numeric[], int) -> numeric[]
   |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
   |
71 | ///  Example: `align_array_and_element(numeric`[], int) -> numeric[]
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: `risingwave_frontend` (lib) generated 3 warnings
    Checking risingwave_ctl v0.1.11 (/Users/yuhao/code/risingwave-dev/src/ctl)
    Checking risingwave_sqlsmith v0.1.11 (/Users/yuhao/code/risingwave-dev/src/tests/sqlsmith)
    Checking risingwave_planner_test v0.1.11 (/Users/yuhao/code/risingwave-dev/src/frontend/planner_test)
    Checking risingwave_simulation v0.1.0 (/Users/yuhao/code/risingwave-dev/src/tests/simulation)
    Checking risingwave_cmd_all v0.1.11 (/Users/yuhao/code/risingwave-dev/src/cmd_all)
    Checking risingwave_cmd v0.1.11 (/Users/yuhao/code/risingwave-dev/src/cmd)
warning: `risingwave_frontend` (lib test) generated 3 warnings (3 duplicates)
    Checking risingwave_sync_point_test v0.1.0 (/Users/yuhao/code/risingwave-dev/src/tests/sync_point)
    Finished dev [unoptimized + debuginfo] target(s) in 44.94s

To Reproduce

Run cargo clippy

Expected behavior

No response

Additional context

May pass CI because the clippy roles are override on linux

[target.x86_64-unknown-linux-gnu]
rustflags = [
    "-Clink-arg=-fuse-ld=lld",
    "-Clink-arg=-Wl,--no-rosegment",
    "-Ctarget-feature=+avx2",
    "--cfg",
    "tokio_unstable",
]

# Remove "-Ctarget-feature=+neon" if your aarch64 target does not support NEON vector extensions
[target.aarch64-unknown-linux-gnu]
rustflags = [
    "-Clink-arg=-fuse-ld=lld",
    "-Clink-arg=-Wl,--no-rosegment",
    "-Ctarget-feature=+neon",
    "--cfg",
    "tokio_unstable",
]

See
rust-lang/cargo#5376
https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags

@yuhao-su yuhao-su added the type/bug Something isn't working label Sep 29, 2022
@github-actions github-actions bot added this to the release-0.1.14 milestone Sep 29, 2022
@fuyufjh
Copy link
Member

fuyufjh commented Sep 30, 2022

https://github.com/risingwavelabs/risingwave/blob/fd25c72f05d80f1a8d428f397680b82276b0fd36/.cargo/config.toml

I guess the rustflags under [build] was overrided in [target.x86_64-unknown-linux-gnu] and [target.aarch64-unknown-linux-gnu]...

@fuyufjh
Copy link
Member

fuyufjh commented Sep 30, 2022

I can take it if nobody is working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants