Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix clippy options (rustflags) #5667

Merged
merged 4 commits into from
Sep 30, 2022
Merged

fix: fix clippy options (rustflags) #5667

merged 4 commits into from
Sep 30, 2022

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Sep 30, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

closes #5652

The format was already corrected by #5651

By the way, fixed a display error in dashboard

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

None

Refer to a related PR or issue link (optional)

#5652

Sorry, something went wrong.

@fuyufjh fuyufjh requested a review from yuhao-su September 30, 2022 08:43
@github-actions github-actions bot added the type/fix Bug fix label Sep 30, 2022
@BugenZhao
Copy link
Member

The Clippy failed. 🥺

@xxchan
Copy link
Member

xxchan commented Sep 30, 2022

target.<cfg>.rustflags
This is similar to the target rustflags, but using a cfg() expression. If several and entries match the current target, the flags are joined together.

And then take precedence over build.rustflags


But I don't know how to deal with -Ctarget-cpu=native 🤔

@BugenZhao
Copy link
Member

target.<cfg>.rustflags

This is similar to the target rustflags, but using a cfg() expression. If several and entries match the current target, the flags are joined together.

And then take precedence over build.rustflags


But I don't know how to deal with -Ctarget-cpu=native 🤔

rust-lang/cargo#11166 🥺

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #5667 (2bdcd22) into main (6ec1948) will decrease coverage by 0.01%.
The diff coverage is 87.00%.

❗ Current head 2bdcd22 differs from pull request most recent head 5ebbeea. Consider uploading reports for the commit 5ebbeea to get more accurate results

@@            Coverage Diff             @@
##             main    #5667      +/-   ##
==========================================
- Coverage   74.32%   74.31%   -0.02%     
==========================================
  Files         919      921       +2     
  Lines      143957   144014      +57     
==========================================
+ Hits       106999   107018      +19     
- Misses      36958    36996      +38     
Flag Coverage Δ
rust 74.31% <87.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/rpc/service/task_service.rs 0.00% <0.00%> (ø)
src/batch/src/task/task_execution.rs 51.28% <0.00%> (-4.09%) ⬇️
src/frontend/src/optimizer/plan_node/mod.rs 98.27% <ø> (ø)
src/frontend/src/optimizer/rule/index_selection.rs 96.08% <ø> (ø)
src/stream/src/cache/lru_manager.rs 13.33% <0.00%> (-0.81%) ⬇️
src/stream/src/executor/mod.rs 53.39% <ø> (ø)
src/stream/src/executor/top_n/group_top_n.rs 88.91% <ø> (ø)
src/stream/src/executor/top_n/top_n_appendonly.rs 95.70% <ø> (ø)
src/stream/src/executor/top_n/top_n_plain.rs 96.78% <ø> (ø)
...frontend/src/optimizer/plan_node/logical_source.rs 77.08% <66.66%> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mergify mergify bot merged commit e69ed7a into main Sep 30, 2022
@mergify mergify bot deleted the eric/fix-clippy-options branch September 30, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo clippy failed on macos
4 participants