Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify for_all macros #5651

Merged
merged 4 commits into from
Sep 29, 2022
Merged

refactor: simplify for_all macros #5651

merged 4 commits into from
Sep 29, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 29, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Remove the extra parameters $(, $x:tt)* in

macro_rules! for_all_xxx {
    ($macro:ident $(, $x:tt)*) 

It's only useful when we want to use a macro multiple times:

for_all_x! { y, a }
for_all_x! { y, b }

But there are no such usage in our codebase. Removing it can make the macros less daunting.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #5651 (6ede8fc) into main (960e11b) will increase coverage by 0.08%.
The diff coverage is 78.96%.

@@            Coverage Diff             @@
##             main    #5651      +/-   ##
==========================================
+ Coverage   74.24%   74.32%   +0.08%     
==========================================
  Files         915      919       +4     
  Lines      143288   143957     +669     
==========================================
+ Hits       106379   106999     +620     
- Misses      36909    36958      +49     
Flag Coverage Δ
rust 74.32% <78.96%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/join/hash_join.rs 95.39% <0.00%> (ø)
src/batch/src/executor/monitor/stats.rs 7.78% <0.00%> (-0.72%) ⬇️
src/common/src/array/data_chunk_iter.rs 85.18% <ø> (ø)
src/common/src/array/error.rs 0.00% <0.00%> (ø)
src/common/src/array/iterator.rs 98.30% <ø> (ø)
src/common/src/array/primitive_array.rs 88.26% <ø> (ø)
src/common/src/types/scalar_impl.rs 68.93% <0.00%> (ø)
src/common/src/util/scan_range.rs 76.64% <ø> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/macros.rs 76.08% <ø> (ø)
... and 123 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 6ec1948 into main Sep 29, 2022
@mergify mergify bot deleted the xxchan/macro branch September 29, 2022 21:10
@fuyufjh fuyufjh mentioned this pull request Sep 30, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants