feat(sink): infer internal table for kv log store in sink #10065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
reviewed
May 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #10065 +/- ##
==========================================
- Coverage 69.95% 69.94% -0.01%
==========================================
Files 1307 1307
Lines 223475 223612 +137
==========================================
+ Hits 156327 156410 +83
- Misses 67148 67202 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
st1page
approved these changes
Jul 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
wenym1
reviewed
Jul 12, 2023
| .add_order_column(SEQ_ID_COLUMN_INDEX, OrderType::ascending_nulls_last()); | ||
| let read_prefix_len_hint = table_catalog_builder.get_current_pk_len(); | ||
|
|
||
| let value_indices = table_catalog_builder.extend_columns(&self.sink_desc().columns); |
There was a problem hiding this comment.
I just tried running with kv log store. It fails because the value_indices of predefined columns are not included here.
We should fix it before merging into main.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kwannoel
pushed a commit
that referenced
this pull request
Jul 14, 2023
Co-authored-by: William Wen <william123.wen@gmail.com> Co-authored-by: William Wen <44139337+wenym1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Infer the internal table for kv log store in sink. The sink executor can construct a kv log store based on the internal table.
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note