Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open append only table in release #11233

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Jul 26, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Some of our users need to define watermark on table.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
CREATE TABLE  table_name ( column_defs ) APPEND ONLY;

The table

  • can accpet INSERT DML, can not accpet UPDATE and DELETE
  • can define watermark columns on it
  • can not define the Primary key on it.

It is a experimental feature

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@st1page st1page requested review from fuyufjh and TennyZhuang July 26, 2023 06:42
@st1page st1page requested a review from yuhao-su July 26, 2023 06:42
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #11233 (b94c8d9) into main (3312e9d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #11233   +/-   ##
=======================================
  Coverage   69.68%   69.68%           
=======================================
  Files        1351     1351           
  Lines      224656   224655    -1     
=======================================
+ Hits       156545   156548    +3     
+ Misses      68111    68107    -4     
Flag Coverage Δ
rust 69.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/frontend/src/handler/create_table.rs 89.98% <100.00%> (+0.04%) ⬆️
src/sqlparser/src/parser.rs 86.35% <100.00%> (+0.07%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TennyZhuang TennyZhuang changed the title chore: open append only table in release feat: open append only table in release Jul 26, 2023
@TennyZhuang TennyZhuang enabled auto-merge July 27, 2023 00:19
@TennyZhuang TennyZhuang added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 226e90f Jul 27, 2023
@TennyZhuang TennyZhuang deleted the sts/open_append_only_table branch July 27, 2023 02:28
@st1page st1page added the user-facing-changes Contains changes that are visible to users label Jul 27, 2023
@emile-00 emile-00 added the 📖✓ Covered or will be covered in the user docs. label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants