Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect compact task memory estimation #14624

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Jan 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Prior to this PR, we mistakenly use the max sst meta size in the level / current sstable size to calculate the max meta ratio, which can be very large when there is a small file. This PR fixes the issue by using current sstable meta size / current sstable size to calculate the ratio instead.

Example task that can cause the issue:

Level 5:
SST1: meta_size = 100KB, SST size = 100MB
SST2: meta_size = 100B, SST size = 1KB

max_meta_ratio  = 100KB / 1KB = 100

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 requested review from Li0k and Little-Wallace January 17, 2024 09:10
@github-actions github-actions bot added the type/fix Bug fix label Jan 17, 2024
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quick fix

@hzxa21 hzxa21 added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 2c2085f Jan 17, 2024
7 of 8 checks passed
@hzxa21 hzxa21 deleted the patrick/fix_compact_task_estimation branch January 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants