Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): make arrangement backfill default #14846

Merged
merged 19 commits into from
Mar 27, 2024
22 changes: 13 additions & 9 deletions ci/scripts/e2e-test-parallel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,29 +26,33 @@ download_and_prepare_rw "$profile" common
echo "--- Download artifacts"
download-and-decompress-artifact e2e_test_generated ./

kill_cluster() {
echo "--- Kill cluster"
cargo make ci-kill
}

host_args="-h localhost -p 4565 -h localhost -p 4566 -h localhost -p 4567"

RUST_LOG="info,risingwave_stream=info,risingwave_batch=info,risingwave_storage=info,risingwave_storage::hummock::compactor::compactor_runner=warn"

echo "--- e2e, ci-3streaming-2serving-3fe, streaming"
RUST_LOG="info,risingwave_stream=info,risingwave_batch=info,risingwave_storage=info" \
RUST_LOG=$RUST_LOG \
cargo make ci-start ci-3streaming-2serving-3fe
sqllogictest ${host_args} -d dev './e2e_test/streaming/**/*.slt' -j 16 --junit "parallel-streaming-${profile}"

echo "--- Kill cluster"
cargo make ci-kill
kill_cluster

echo "--- e2e, ci-3streaming-2serving-3fe, batch"
RUST_LOG="info,risingwave_stream=info,risingwave_batch=info,risingwave_storage=info" \
RUST_LOG=$RUST_LOG \
cargo make ci-start ci-3streaming-2serving-3fe
sqllogictest ${host_args} -d dev './e2e_test/ddl/**/*.slt' --junit "parallel-batch-ddl-${profile}"
sqllogictest ${host_args} -d dev './e2e_test/visibility_mode/*.slt' -j 16 --junit "parallel-batch-${profile}"

echo "--- Kill cluster"
cargo make ci-kill
kill_cluster

echo "--- e2e, ci-3streaming-2serving-3fe, generated"
RUST_LOG="info,risingwave_stream=info,risingwave_batch=info,risingwave_storage=info" \
RUST_LOG=$RUST_LOG \
cargo make ci-start ci-3streaming-2serving-3fe
sqllogictest ${host_args} -d dev './e2e_test/generated/**/*.slt' -j 16 --junit "parallel-generated-${profile}"

echo "--- Kill cluster"
cargo make ci-kill
kill_cluster
8 changes: 4 additions & 4 deletions ci/workflows/main-cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ steps:

- label: "end-to-end test (madsim)"
key: "e2e-test-deterministic"
command: "TEST_NUM=64 timeout 55m ci/scripts/deterministic-e2e-test.sh"
command: "TEST_NUM=64 timeout 75m ci/scripts/deterministic-e2e-test.sh"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-e2e-test-deterministic-simulation"
Expand All @@ -353,7 +353,7 @@ steps:
environment:
- GITHUB_TOKEN
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 60
timeout_in_minutes: 80
retry: *auto-retry

- label: "recovery test (madsim)"
Expand Down Expand Up @@ -396,7 +396,7 @@ steps:
# Ddl statements will randomly run with background_ddl.
- label: "background_ddl recovery test (madsim)"
key: "background-ddl-recovery-test-deterministic"
command: "TEST_NUM=12 KILL_RATE=1.0 BACKGROUND_DDL_RATE=0.8 timeout 55m ci/scripts/deterministic-recovery-test.sh"
command: "TEST_NUM=12 KILL_RATE=1.0 BACKGROUND_DDL_RATE=0.8 timeout 60m ci/scripts/deterministic-recovery-test.sh"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-recovery-test-deterministic-simulation"
Expand All @@ -409,7 +409,7 @@ steps:
mount-buildkite-agent: true
# Only upload zipped files, otherwise the logs is too much.
- ./ci/plugins/upload-failure-logs-zipped
timeout_in_minutes: 60
timeout_in_minutes: 65
retry: *auto-retry

- label: "end-to-end iceberg sink test (release)"
Expand Down
7 changes: 4 additions & 3 deletions ci/workflows/pull-request.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
auto-retry: &auto-retry

automatic:
# Agent terminated because the AWS EC2 spot instance killed by AWS.
- signal_reason: agent_stop
Expand Down Expand Up @@ -96,7 +97,7 @@ steps:
config: ci/docker-compose.yml
mount-buildkite-agent: true
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 19
timeout_in_minutes: 21
retry: *auto-retry

- label: "end-to-end test (parallel)"
Expand Down Expand Up @@ -476,7 +477,7 @@ steps:
run: rw-build-env
config: ci/docker-compose.yml
mount-buildkite-agent: true
timeout_in_minutes: 10
timeout_in_minutes: 12
cancel_on_build_failing: true
retry: *auto-retry

Expand Down Expand Up @@ -514,7 +515,7 @@ steps:
environment:
- GITHUB_TOKEN
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 21
timeout_in_minutes: 25
cancel_on_build_failing: true
retry: *auto-retry

Expand Down
3 changes: 3 additions & 0 deletions e2e_test/sink/sink_into_table/parallelism.slt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
statement ok
set streaming_use_arrangement_backfill=false;

statement ok
SET RW_IMPLICIT_FLUSH TO true;

Expand Down
2 changes: 1 addition & 1 deletion src/common/src/session_config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ pub struct ConfigMap {
streaming_enable_bushy_join: bool,

/// Enable arrangement backfill for streaming queries. Defaults to false.
#[parameter(default = false)]
#[parameter(default = true)]
streaming_use_arrangement_backfill: bool,

/// Allow `jsonb` in stream key
Expand Down
Loading
Loading